microcks / microcks/microcks-cli
microcks import truncates Windows absolute paths when parsing :primary suffix
Personne n'a encore pris cette issue.
- Langage dominant
- Go
- Étoiles
- 52
- Forks
- 68
- Merge moyen
- 6 h 54 min
- PR mergées (30 j)
- 10
Description
Describe the bug
microcks import supports an optional :true / :false suffix to mark whether an imported artifact is the main artifact. However, the current parser at cmd/import.go:126 uses strings.Split(f, ":"), which also splits Windows-absolute paths on the drive-letter colon. A path such as:
C:\Temp\api.yaml
is therefore truncated to just C, and the remainder is treated as the boolean suffix — which then fails to parse, falls back to mainArtifact = true, and the upload step opens C (which does not exist).
Expected behavior
Windows-absolute paths should be preserved as full file paths.
C:\Temp\api.yaml should be parsed as:
path = C:\Temp\api.yaml
mainArtifact = true
C:\Temp\api.yaml:false should be parsed as:
path = C:\Temp\api.yaml
mainArtifact = false
The existing documented suffix behavior should continue to work for relative paths:
./api.yaml -> path = ./api.yaml, mainArtifact = true
./api.yaml:true -> path = ./api.yaml, mainArtifact = true
./api.yaml:false -> path = ./api.yaml, mainArtifact = false
In short: the parser should be able to tell the drive-letter colon apart from the suffix-separator colon.
Actual behavior
The current parser splits on every colon and only ever inspects parts[1].
A Windows path like C:\Temp\api.yaml is parsed as:
parts = ["C", "\Temp\api.yaml"]
path = "C"
mainArtifact = true (strconv.ParseBool fails on "\Temp\api.yaml", default is true)
A Windows path with an explicit suffix like C:\Temp\api.yaml:false is parsed as:
parts = ["C", "\Temp\api.yaml", "false"]
path = "C"
mainArtifact = true (only parts[1] is read; the trailing "false" is never seen)
In both cases the subsequent upload fails with open C: no such file or directory, with no hint that the parser silently truncated the path.
How to Reproduce?
- On Windows, place an OpenAPI file at
C:\Temp\api.yaml. - Build the CLI:
make build-local. - Run:
./build/dist/microcks.exe import C:\Temp\api.yaml --microcksURL http://localhost:8585 - Observe the failure:
open C: no such file or directory(sometimes preceded byCannot parse '\Temp\api.yaml' as Bool, default to true).
The same shape of bug is reproducible on Linux/macOS by passing a path that contains a colon, e.g. path:with:colon.yaml.
Microcks version or git rev
No response
Install method (docker-compose, helm chart, operator, docker-desktop extension,...)
No response
Additional information
Root cause. cmd/import.go:125-131 parses each comma-separated entry by:
if strings.Contains(f, ":") {
pathAndMainArtifact := strings.Split(f, ":")
f = pathAndMainArtifact[0]
mainArtifact, err = strconv.ParseBool(pathAndMainArtifact[1])
...
}
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez dans cmd/import.go:125-131, où les entrées d’import séparées par des virgules sont analysées avec strings.Split. Compilez avec make build-local et testez les chemins relatifs, les chemins au format lettre de lecteur Windows et les chemins avec des suffixes true ou false explicites. Le travail est terminé lorsque le chemin complet est conservé et que le suffixe continue de déterminer mainArtifact sans perturber le comportement existant des chemins relatifs.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- go
- Domaine
- cli
- Type d'issue
- Bug
- Difficulté
- 2/5
- Temps estimé
- 1-3 heures
- Activité
- Calme
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 78/100