micro-ROS / micro-ROS/micro-ROS-demos
Disable fuchsia-related checks in clang-tidy
Open
@BorjaOuterelo is already working on this.
Since Jan 16, 2019.
enhancement
- Dominant language
- C
- Stars
- 101
- Forks
- 35
- Avg merge
- 4d 16h
- Merged PRs (30d)
- 3
Description
Compiling the demos leads to a lot of warnings from clang-tidy, many of which are from the Fuchsia warning set, such as "fuchsia-default-arguments". Fuchsia has a very specific style guide which is not generally appropriate, e.g., calling functions with default arguments is valid C++ practice, but disallowed by Fuchsia.
I would suggest the following list instead of "*" as used currently:
bugprone-*,cert-*,clang-analyzer-*,cppcoreguidelines-*,google-*,hicpp-*,llvm-*,misc-*,modernize-*,performance-*,readability-*
Opinions?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.