micro-ROS / micro-ROS/micro-ROS-Agent

Dependencies missing in manifest

Open
#105 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
201
Forks
111
Avg merge
1d 6h
Merged PRs (30d)
10

Description

**Describe the bug**
Dependencies [declared as required in cmake](https://github.com/micro-ROS/micro-ROS-Agent/blob/galactic/micro_ros_agent/CMakeLists.txt#L32-L50) are missing [in the manifest file](https://github.com/micro-ROS/micro-ROS-Agent/blob/galactic/micro_ros_agent/package.xml#L18-L22).

**To reproduce**
I encountered this issue when trying to revive an old micro-ROS agent (foxy) installation on my ubuntu PC. Following [this tutorial](https://micro.ros.org/docs/tutorials/core/first_application_linux/), I
1. Pulled the micro_ros_setup repo
2. Executed create_agent_ws
3. Executed build_agent
---- Up to here it is expected behavior, the agent is built properly.

When I then execute `colcon build` in my ROS 2 workspace, the build of the micro_ros_agent package fails as it is missing microxrcedds_agent. When I place the microxrcedds_agent repo in my workspace, it will still fail on the first colcon run, since microxrcedds_agent is not specified as dependency in the micro-ROS agent package manifest, so colcon doesn't know to build it first.

**Expected behaviour**
All ROS 2 packages in my workspace successfully build

**System information (please complete the following information):**
Ubuntu 20.04, ROS 2 foxy, latest foxy branch

Contributor guide

Open the contributing guide

Research direction

Compare the dependencies declared in micro_ros_agent/CMakeLists.txt at lines 32-50 with micro_ros_agent/package.xml at lines 18-22. Start by reading both files, then run colcon build in a ROS 2 workspace containing micro_ros_agent and microxrcedds_agent. Done means the packages build successfully in dependency order.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.