mi6 / mi6/ic-ui-kit

Z-index is not correct for sticky ic-page-header

Open
#653 1 comment 0 reactions 1 assignee View on GitHub

@MI6-806 is already working on this.

Since Jun 9, 2023.

good first issue page-header component
Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

## Summary of the bug
Spotted on the guidance site, the page header is sticky and should be shown above any page content. However, the ic-menu is displayed over it when it is opened and the page is scrolled.

## 🪜 How to reproduce
1. Go to https://design.sis.gov.uk/components/select.
2. Click the select example on the guidance tab so that the menu is open.
3. Scroll down whilst keeping the menu open.
4. The menu will appear above the sticky page header.

## 🧐 Expected behaviour
A sticky page header should cover all page content.

## 📸 Screenshots or code
![Screenshot from 2023-05-05 16-01-41](https://user-images.githubusercontent.com/117368893/236495128-db1b3293-2500-4533-b74b-970f877f13ae.png)

## Additional info
Will maybe need a new design token for a sticky page header z-index. Could then add that to page header when the sticky prop is applied.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.