matrix-org / matrix-org/python-canonicaljson
There are no tests to ensure that floats fail
Open
Nobody has claimed this yet.
bug
help wanted
- Dominant language
- Python
- Stars
- 30
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
As per spec:
>Numbers in the JSON must be integers in the range `[-(2**53)+1, (2**53)-1]`.
There isn't any code that checks for floats, either.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the number serialization and existing test suite in the repository, then trace how numeric values are handled. Add regression coverage for floats and the specified integer range, and run the full test suite to confirm invalid numbers fail without breaking supported canonical JSON.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100