matrix-org / matrix-org/python-canonicaljson

There are no tests to ensure that floats fail

Open
#22 8 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Python
Stars
30
Forks
15
PR merge metrics
No merged PRs in 30d

Description

As per spec:

>Numbers in the JSON must be integers in the range `[-(2**53)+1, (2**53)-1]`.

There isn't any code that checks for floats, either.

Contributor guide

Open the contributing guide

Research direction

Start by locating the number serialization and existing test suite in the repository, then trace how numeric values are handled. Add regression coverage for floats and the specified integer range, and run the full test suite to confirm invalid numbers fail without breaking supported canonical JSON.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.