matrix-org / matrix-org/matrix-python-sdk

Event object no longer has "membership" key

Open
#317 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
266
Forks
118
PR merge metrics
No merged PRs in 30d

Description

First reported at https://github.com/zulip/python-zulip-api/issues/612. For example, code like https://github.com/matrix-org/matrix-python-sdk/blob/a469d531b6879c5687718937a0bfcb443155ce43/samples/SimpleChatClient.py#L26 no longer works.

The list of keys of the event object as of now:
`['unsigned', 'origin_server_ts', 'type', 'room_id', 'content', 'sender', 'event_id']`.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the SDK constructs the event object and compare its current keys with the membership access in samples/SimpleChatClient.py at line 26. Confirm the intended event shape from the linked report, restore the missing membership data if appropriate, and verify that the sample no longer fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.