matrix-org / matrix-org/matrix-python-sdk

MatrixRequestError.content should be parsed

Open
#225 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Api layer bug enhancement
Dominant language
Python
Stars
266
Forks
118
PR merge metrics
No merged PRs in 30d

Description

Currently the ``content`` is left as a JSON string which means the end application has to parse it, when really it could be done at the api level. Alternatively the ``errcode`` and ``error`` keys could be part of the exception object.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating MatrixRequestError and the code that constructs it, then inspect how response content, errcode, and error are currently exposed. The issue presents two alternatives, so completion requires deciding whether content should be parsed or the exception should expose errcode and error, with tests confirming the chosen behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.