matrix-org / matrix-org/matrix-python-sdk

Create filter class that can be passed as parameter on all requests

Open
#187 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

architecture breaking Client layer enhancement
Dominant language
Python
Stars
266
Forks
118
PR merge metrics
No merged PRs in 30d

Description

Need to figure out if this lives at client level or api level. ~In meantime, limit parameter should be undeprecatedi~ `limit` parameter no longer exists.

This is related to #153, but #153 is about automatically creating filters while this one is about allowing users to manually create and apply filters.

At the moment I can't remember whether filters have use outside of `sync` or not. If they don't, someone let me know, and I'll modify title accordingly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test paths are named. Start by tracing how requests are handled at the client and API levels, then check whether filters are used outside sync; done means users can manually create and apply a filter to every request, distinct from the automatic filter creation in #153.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.