matrix-org / matrix-org/matrix-python-common
Factor out `MatrixFederationAgent`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Sydent: sydent/sydent/http/matrixfederationagent.py
synapse: synapse/synapse/http/federation/matrix_federation_agent.py
And possibly these two in Synapse too?
```
synapse/tests/http/test_proxyagent.py
211:class MatrixFederationAgentTests(TestCase):
synapse/tests/http/federation/test_matrix_federation_agent.py
64:class MatrixFederationAgentTests(unittest.TestCase):
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare sydent/sydent/http/matrixfederationagent.py with synapse/synapse/http/federation/matrix_federation_agent.py to identify the shared implementation. Then review synapse/tests/http/test_proxyagent.py and synapse/tests/http/federation/test_matrix_federation_agent.py, including their MatrixFederationAgentTests classes. Done means the common code is factored out and the relevant tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100