matplotlib / matplotlib/matplotlib
Deprecate bbox and xy parameters to restore_region?
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 23.2k
- 分支
- 8.5k
- 平均合併
- 1 天 6 小時
- 30 天內合併 PR
- 66
描述
Describe the issue
Summary
RendererAgg.restore_region takes two optional kwargs, bbox and xy, which specify respectively a subregion and and offset for the restoring. These were introduced in b1c784d for manual animations where subregions of specific patterns would be blitted with certain offsets. This was demonstrated in a single example, which was removed in e547d6f, and never used anywhere else.
I would suggest deprecating and then getting rid of the feature: there doesn't seem to be much demand for it (no other use anywhere in the library or the examples); the kind of animation it allows is extremely specific, and likely it should be possible to build something similarly efficient using FigureImage (i.e., drawing a non-resampled array at a given position should really just involve setting the correspoding pixels in the bitmap) anyways.
Also, that means one less thing to implement in mplcairo for feature parity :)
Is there anyone opposed to such a removal?
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 RendererAgg.restore_region 進入點開始,核查其 bbox 和 xy 參數在整個程式庫和範例中的已回報使用情況。檢視此 API 的棄用和移除預期;完成的標準是:在不破壞剩餘使用情況或與 mplcairo 的對等性的前提下,為這項過時功能確定一條已達成共識且完整的移除路徑。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- data-visualization
- Issue 類型
- 重構
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100