material-components / material-components/material-components-android

[Docs][BottomSheet][SideSheet] Difference between spec and implementation

Open
#4,792 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
17.4k
Forks
3.2k
PR merge metrics
No merged PRs in 30d

Description

Update the docs or the implementation.

BottomSheet

Description:
https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/bottomsheet/res/values/styles.xml#L73:

<item name="backgroundTint">@macro/m3_comp_sheet_bottom_docked_container_color</item>

https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/bottomsheet/res/values/tokens.xml#L24:

<macro name="m3_comp_sheet_bottom_docked_container_color">?attr/colorSurfaceContainerLow</macro>

https://m3.material.io/components/bottom-sheets/specs:


(3) Surface

Expected behavior:
https://m3.material.io/components/bottom-sheets/specs:

(3) Surface container low

SideSheet

Description:
https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/sidesheet/res/values/styles.xml#L49:

<item name="backgroundTint">@macro/m3_comp_sheet_side_docked_modal_container_color</item>

https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/sidesheet/res/values/tokens.xml#L24:

<macro name="m3_comp_sheet_side_docked_modal_container_color">?attr/colorSurfaceContainerLow</macro>

https://m3.material.io/components/side-sheets/specs:

Modal side sheet color

(3) Surface

Expected behavior:
https://m3.material.io/components/side-sheets/specs:

(3) Surface container low

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the BottomSheet and SideSheet backgroundTint entries and token definitions in their linked styles.xml and tokens.xml files with the corresponding Material 3 specification pages. First determine whether the specification or implementation is authoritative; done means the documented surface color and the component behavior agree for both sheets.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
design, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.