material-components / material-components/material-components-android

[Search] Unable to apply search string to RecyclerView

Offen
#4,348 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

bug Widget: Search
Vorherrschende Sprache
Java
Sterne
17.4k
Forks
3.2k
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Description: I have below structure in my activity_main.xml, incl. SearchBar and SearchView, similar to the documentation. I'm using a ViewPager2 with fragments (one for each tab of the TabLayout, including each a RecyclerView list). Basically, the GUI looks like the Catalog app RecyclerView Demo.

<?xml version="1.0" encoding="utf-8"?>
<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:id="@+id/main_content"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:fitsSystemWindows="true"
    android:layoutDirection="locale"
    android:textDirection="locale"
    tools:context=".MainActivity">

    <com.google.android.material.appbar.AppBarLayout
        android:id="@+id/appbar"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:stateListAnimator="@null"
        android:fitsSystemWindows="true">

        <com.google.android.material.appbar.MaterialToolbar
            android:id="@+id/toolbar"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:minHeight="?attr/actionBarSize"
            app:layout_scrollFlags="scroll|enterAlways|snap"
            app:layout_scrollEffect="compress" />

        <com.google.android.material.tabs.TabLayout
            android:id="@+id/tabs"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:background="@android:color/transparent"
            android:contentDescription="@string/app_name"
            app:layout_scrollFlags="scroll|enterAlways"
            app:tabMode="scrollable" />

        <com.google.android.material.search.SearchBar
            android:id="@+id/search_bar"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:hint="searchbar_hint" />

    </com.google.android.material.appbar.AppBarLayout>

    <com.google.android.material.search.SearchView
        android:id="@+id/search_view"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:hint="searchview_hint"
        app:layout_anchor="@id/search_bar">

        <androidx.recyclerview.widget.RecyclerView
            android:id="@+id/search_results_recycler_view"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:scrollbars="vertical" />

    </com.google.android.material.search.SearchView>

    <androidx.viewpager2.widget.ViewPager2
        android:id="@+id/container"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:clipChildren="false"
        android:clipToPadding="false"
        app:layout_behavior="@string/appbar_scrolling_view_behavior" />

</androidx.coordinatorlayout.widget.CoordinatorLayout>

Expected behavior: This is how I understand the Material Design search functionality for my use case:

  • I click on the SearchBar, the SearchView opens. I enter a search string, the original RecyclerView of the currently selected tab will be searched for the string and the results are shown in the RecyclerView with id search_results_recycler_view (i.e. the one within SearchView).
  • With setOnEditorActionListener / SearchView.getText, I'm listening for the search string.

Setup:

  • SearchBar and SearchView are defined in MainActivity
  • RecyclerViews and adapters are defined in the fragments
  • Custom adapter for RecyclerView has a getFilter() method implemented

The problem is that I'm not sure on how to...
a) transfer the search string from SearchView to the original RecyclerView list of the currently selected tab and then...
b) transfer the filtered list back to the RecyclerView with id search_results_recycler_view within SearchView.

Shall I use a ViewModel for each transfer part? Easy for a) where I can use String, but for b) it tricky as ViewModel doesn't allow an ArrayList<CustomAdapter>?

The Catalog RecyclerView Demo also doesn't show how to do that as all search results are hard-coded and have no association with the original text, so entering a search string has no effect.

Can you please share some insights (e.g. in the documentation) on how to implement this (best practice) or would you be able to amend the Catalog demo accordingly?

Source code: See above XML code.

Android API version: Tested on Android API 30-35

Material Library version: 1.13.0-alpha07

Device: Pixel 8 emulators, Nokia 7.2

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne mit docs/components/Search.md und catalog/java/io/material/catalog/search/SearchRecyclerDemoActivity.java und verfolge dann activity_main.xml, die ViewPager2-Fragmente und ihre RecyclerView-Adapter. Ermittle, wie der aktuelle Tab, der Suchtext und die gefilterten Ergebnisse miteinander verbunden werden sollen. Als erledigt gilt die Aufgabe, wenn das dokumentierte Muster oder das Katalogbeispiel eine echte Suche ausführt und die passenden Ergebnisse in search_results_recycler_view anzeigt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
android, java, xml
Bereich
documentation, mobile
Issue-Typ
Dokumentation
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
30/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.