material-components / material-components/material-components-android
[BottomSheet] sample can't be built, docs and sample don't match, and missing information of edge-to-edge
Nessuno ha ancora preso questa issue.
- Lingua principale
- Java
- Stelle
- 17.4k
- Fork
- 3.2k
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Description: Full description of issue here
Right now, if you check the sample "catalog" and reach the bottom sheet code, you will see it's quite old, not matching the docs, and even reaches protected API of the library:
The docs say to use "enableEdgeToEdge " and setting "navigationBarColor" to be transparent, but the sample doesn't have any of these:
Not to mention the sample doesn't even build fine, so I can't run it to see how well it works other than using the release-apk of the repository.
studio64_2024-08-05_21-53-35.zip
Expected behavior: Screenshots and/or description of expected behavior
- The sample should match the latest APIs that are documented and recommended.
- The sample should be built fine using latest Android Studio version.
- The docs should mention what it means
app:enableEdgeToEdge is true, because it doesn't show it in the snippets and doesn't mention it anywhere there, of where to put it.
Source code: The code snippet which is causing this issue
All here (sadly can't attach, as it's beyond max attachment file limits) :
https://github.com/material-components/material-components-android
Minimal sample app repro: Please consider attaching a minimal sample app that reproduces the issue. This will help narrow down the conditions required for reproducing the issue, and it will speed up the bug fix process. You may attach a zip file of the sample app or link to a GitHub repo that contains the sample app.
All here (sadly can't attach, as it's beyond max attachment file limits) :
https://github.com/material-components/material-components-android
Android API version: Android API version here
It's before reaching this phase.
Material Library version: Material Android Library version you are using here (e.g., 1.1.0-alpha07)
1.13.0-alpha04
Device: Device on which the bug was encountered here
PC.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia da catalog/java/io/material/catalog/bottomsheet/BottomSheetScrollableContentDemoFragment.java e confrontalo con docs/components/BottomSheet.md. Esegui la build di catalog/sample per identificare l’errore attuale e verifica come si applica la configurazione edge-to-edge documentata. Il lavoro è completato quando l’esempio viene compilato, utilizza le API documentate e la documentazione spiega dove deve essere inserito app:enableEdgeToEdge.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- android, java
- Ambito
- build-system, documentation, mobile
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100