mapstruct / mapstruct/mapstruct-idea

multiple line expression syntax check is broken

Open
#82 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
168
Forks
41
PR merge metrics
No merged PRs in 30d

Description

when write expression in multiple lines, syntax check works unexpected.
eg:

@Mapping(target = "totalAmount", expression = "java(a.getDetailList().stream()" + 
".map(ADetail::getAmount).reduce(BigDecimal.ZERO, BigDecimal::add))")
B a2b(A a);

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the multiline Java expression shown in the issue and inspect the plugin's syntax-checking entry point for MapStruct expressions. The payload names no files or tests; done means the example is checked correctly without a false syntax error, with coverage added for multiline expressions if the existing test structure is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.