mapstruct / mapstruct/mapstruct-idea
Completion for java "expression" does't work with DTO as records
未关闭
还没有人认领这个 Issue。
- 主要语言
- Java
- 星标
- 168
- 派生
- 41
- PR 合并指标
- 30 天内没有已合并 PR
描述
Example mapper:
@Mapper(unmappedTargetPolicy = ReportingPolicy.IGNORE, componentModel = MappingConstants.ComponentModel.SPRING)
public interface OrderMapper {
OrderGetAllDto toOrderDto(Order order);
default <T, R> R mapFromAggregateReference(AggregateReference<T, R> aggregateReference) {
if (aggregateReference == null) {
return null;
}
return aggregateReference.getId();
}
@Mapping(target = "orderPaymentRefPayments", expression = "java(orderPaymentRefsToOrderPaymentRefPayments())")
OrderDto toOrderGetOneDto(Order order);
default Set<Long> orderPaymentRefsToOrderPaymentRefPayments(Set<OrderPaymentRef> orderPaymentRefs) {
return orderPaymentRefs.stream()
.map(OrderPaymentRef::getPayment)
.map(AggregateReference::getId)
.collect(Collectors.toSet());
}
}
DTO as JAVA record:
public record OrderDto(Long id, String number, Integer owner, Set<Long> orderPaymentRefPayments,
List<OrderItemDto> orderItems, BigDecimal totalCost, LocalDateTime createdDate,
LocalDateTime lastModifiedDate) {
/**
* DTO for {@link OrderItem}
*/
public record OrderItemDto(Long id, Long service, Integer quantity, String serviceName, BigDecimal price,
BigDecimal cost) {
}
}
When writing an JAVA expression for
@Mapping(target = "orderPaymentRefPayments", expression = "java()")
completion hints are not displayed.
Because OrderDto is a record and it's not possible to resolve target type in sources org.mapstruct.intellij.expression.JavaExpressionInjector, see
PsiElement resolved = references[0].resolve();
if ( resolved instanceof PsiMethod resolvedPsiMethod ) {
PsiParameter[] psiParameters =
resolvedPsiMethod.getParameterList().getParameters();
if ( psiParameters.length > 0) {
targetType = psiParameters[0].getType();
}
}
else if ( resolved instanceof PsiParameter resolvedPsiParameter ) {
targetType = resolvedPsiParameter.getType();
}
else if ( resolved instanceof PsiField resolvedPsiField ) {
targetType = resolvedPsiField.getType();
}
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 org.mapstruct.intellij.expression.JavaExpressionInjector 开始,检查已解析的目标如何针对 Java 表达式转换为类型。使用 OrderDto record 重现补全请求,并检查 orderPaymentRefPayments 是否出现补全提示;完成标准是 record component 的目标类型已解析,同时不回归现有的字段、方法或参数处理。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- java
- 领域
- devtools
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100