mapbox / mapbox/osmpbf-tutorial
The hex->binary images for 0x10 and 0x18 are wrong
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 23
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
For 0x10 (./i/10_fieldwire.gif)
0x10 -> 0001 0000 # cool
split to field and wire of 00010 and 000, # good so far
but the label under field is "1" instead of "2"
and the label under wire is "2" instead of "0"
For 0x18 (./i/18_fieldwire.gif)
0x18 -> 0001 1000 # cool
field is 00011 and wire is 000 # yup
field's label is "3" which is correct, but
wire's label is "2" again, instead of "0"
I'm not sure how that effects the explanations of what the fields mean.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open i/10_fieldwire.gif and i/18_fieldwire.gif and compare their field and wire labels with the binary splits described in the issue. Update the two images so the labels match the stated values, then verify that the resulting diagrams agree with the surrounding explanation.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100