mapbox / mapbox/node-cpp-skel

fix travis build issue

Open
#157 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
74
Forks
9
PR merge metrics
No merged PRs in 30d

Description

This morning, I found that all the c++ build job related to "TOOLSET=asan" returns an error, even we try to rebuild the old jobs which already passed:

image

image

Debug w/ @springmeyer, we thought this is a new Travis error due to a new leak in node.js.

To fix this issue we need to add echo "leak:node::Start" >> ${SUPPRESSION_FILE} in scripts/sanitize.sh

diff --git a/scripts/sanitize.sh b/scripts/sanitize.sh
index 4168cca..28c9344 100755
--- a/scripts/sanitize.sh
+++ b/scripts/sanitize.sh
@@ -24,6 +24,7 @@ SUPPRESSION_FILE="/tmp/leak_suppressions.txt"
 echo "leak:__strdup" > ${SUPPRESSION_FILE}
 echo "leak:v8::internal" >> ${SUPPRESSION_FILE}
 echo "leak:node::CreateEnvironment" >> ${SUPPRESSION_FILE}
+echo "leak:node::Start" >> ${SUPPRESSION_FILE}
 echo "leak:node::Init" >> ${SUPPRESSION_FILE}
 export ASAN_SYMBOLIZER_PATH=$(pwd)/mason_packages/.link/bin/llvm-symbolizer
 export MSAN_SYMBOLIZER_PATH=$(pwd)/mason_packages/.link/bin/llvm-symbolizer

OR see this PR https://github.com/mapbox/node-cpp-skel/pull/156/files.

This will fix the issue.

cc w/ @mapbox/maps-api @flippmoke @mapsam @millzpaugh

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with scripts/sanitize.sh and the Travis jobs using TOOLSET=asan. Compare the sanitizer suppression entries with the referenced node-cpp-skel pull request, then rerun or inspect the affected C++ ASAN build; done means the ASAN jobs complete without the reported Node.js leak failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, node.js, shell
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.