mapbox / mapbox/node-cpp-skel

Feature request: Make it possible to check c++ version in same place

Open
#140 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
74
Forks
9
PR merge metrics
No merged PRs in 30d

Description

We currently have to put the c++ version in two place, (1) common.gypi and (2) binding.gyp:

Let's add a shared variable for c++ version that we can use in these two places.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the C++ version settings at common.gypi line 5 and binding.gyp line 110. Inspect how those two files currently specify the version, then identify a shared variable that both places can use. Done means the version is defined once and both build configuration locations consume it consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, node.js
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.