mapbox / mapbox/mapbox-navigation-android
Inefficient use of MapboxRouteLineApi cache for restricted sections
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Kotlin
- Sterne
- 651
- Forks
- 321
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Whenever the MapboxRouteLineApi needs to update the vanishing point (MapboxRouteLineApi#updateTraveledRouteLine), MapboxRouteLineOptions#styleInactiveRouteLegsIndependently is enabled, and the route goes through a visualized restricted section, the API needs to extract the full parsed route object to create the gradient expression for the restricted sections:
https://github.com/mapbox/mapbox-navigation-android/blob/d8d04fe75e53063f5e185c3779c04c7b0914f77d/libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineApi.kt#L463-L470
This parsed data is already cached in
https://github.com/mapbox/mapbox-navigation-android/blob/d8d04fe75e53063f5e185c3779c04c7b0914f77d/libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/internal/route/line/MapboxRouteLineUtils.kt#L67-L72
however, the key of this cache is based on the hash of the full DirectionsRoute, which makes computing the key very expensive for long routes.
While this is not as problematic when routes are re-drawn (for each MapboxRouteLineApi#setNavigationRoutes), it is extremely unsuitable for very frequent updates of the vanishing point with MapboxRouteLineApi#updateTraveledRouteLine. This cache lookup on a route from Munich to Madrid can take more than 20% of the main thread's time on a rather powerful Samsung S22+, and on other hardware can even occasionally lead to ANRs if the frequency of the location indicator updates is high enough to flood the main thread.

During the vanishing updates, they cache element is not possible to be changed, so instead of extracting the value from the cache on each update, we should store the List<ExtractedRouteData> locally in MapboxRouteLineApi and refresh it whenever routes are re-drawn. We already follow the same practice with the List<RouteLineExpressionData>:
https://github.com/mapbox/mapbox-navigation-android/blob/d8d04fe75e53063f5e185c3779c04c7b0914f77d/libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineApi.kt#L199
cc @cafesilencio @abhishek1508
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne in MapboxRouteLineApi.kt bei updateTraveledRouteLine und setNavigationRoutes und untersuche anschließend MapboxRouteLineUtils.kt, wo ExtractedRouteData zwischengespeichert wird. Halte die extrahierten Routendaten lokal in MapboxRouteLineApi vor und aktualisiere sie, wenn Routen neu gezeichnet werden, damit Aktualisierungen des Fluchtpunkts den aufwendigen Routen-Hash und die Cache-Suche nicht mehr neu berechnen.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- android, kotlin
- Bereich
- mobile-dev, performance
- Issue-Typ
- Refactoring
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 38/100