mapbox / mapbox/mapbox-navigation-android
Deliver routes back in RoutesObserver only when they were processed successfully
@dzinad arbeitet bereits daran.
Seit 17.6.2022.
- Vorherrschende Sprache
- Kotlin
- Sterne
- 651
- Forks
- 321
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Refs https://github.com/mapbox/mapbox-navigation-android/pull/5653 where we introduced a dependency for `MapboxNavigation#setNavigationRoutes` to only deliver the routes back in `RoutesObserver` after they were processed by the native navigator.
This opens up an opportunity to only return routes that were _successfully_ processed by the native navigator. A route might be valid for display on the map, valid for camera operations, etc. while for any reason not being valid for navigation from Nav Native perspective. Filtering invalid routes out would prevent user confusion and made it easier for developers to catch a problem if a route they set is not delivered back.
We could extend the `RoutesUpdatedResult` with a collection of routes that were not processed successfully and the reasons for that.
cc @Guardiola31337 @RingerJK @VysotskiVadim
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Bewertung
Dieses Issue wurde noch nicht bewertet.