mapbox / mapbox/mapbox-navigation-android
Deliver routes back in RoutesObserver only when they were processed successfully
@dzinad is already working on this.
Since Jun 17, 2022.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
Refs https://github.com/mapbox/mapbox-navigation-android/pull/5653 where we introduced a dependency for `MapboxNavigation#setNavigationRoutes` to only deliver the routes back in `RoutesObserver` after they were processed by the native navigator.
This opens up an opportunity to only return routes that were _successfully_ processed by the native navigator. A route might be valid for display on the map, valid for camera operations, etc. while for any reason not being valid for navigation from Nav Native perspective. Filtering invalid routes out would prevent user confusion and made it easier for developers to catch a problem if a route they set is not delivered back.
We could extend the `RoutesUpdatedResult` with a collection of routes that were not processed successfully and the reasons for that.
cc @Guardiola31337 @RingerJK @VysotskiVadim
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.