mapbox / mapbox/mapbox-navigation-android
Call RerouteController#interrupt() when going OnRoute
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
When going OFF_ROUTE, `RerouteController#reroute()` is called.
If the Rerouting is not yet finished and the user goes back on the route (e.g. minor GPS discrepancy), the `interrupt()` should be called to avoid changing the route (for example remove silent waypoints).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the transition to OnRoute and the existing RerouteController#reroute() call described in the issue. Check how an unfinished reroute is represented, then verify that returning on route interrupts it and avoids route changes such as removing silent waypoints. The issue names no files or tests, so locate the relevant navigation and controller tests before making the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100