mapbox / mapbox/mapbox-navigation-android

Crash: Attempt to invoke virtual method 'void com.mapbox.navigation.ui.MultiOnClickListener.clearListeners()' on a null object reference

Aperta
#3,901 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
Kotlin
Stelle
651
Fork
321
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Android API:
Mapbox Navigation SDK version: 9.6.0 and Navigator 1.1.0 & 1.3.0

Steps to trigger behavior
  1. Basically I'm using the sample from here https://docs.mapbox.com/android/navigation/guides/install/ (however it is converted into a different language).
  2. Pause/Switch Application
Expected behavior

No Crash

Actual behavior

Crash

Appears to be like #1971, however the stack trace appears to be slightly different.


This occurs when I click the Switch application button (i.e. Square Nav Button); the app throws this error. I am logging all the events; and I see:
The Pause & Stop events in sequence, which I then chain to the MapBox Navigator onPause, onStop calls exactly like the demo. However about 1/2 a second after; I get the below stack trace crash.... I've also tried not sending the onStop, onPause, etc... No change...

Based on the callstack below; I suspect the issue is something has already called:
https://github.com/mapbox/mapbox-navigation-android/blob/master/libnavigation-ui/src/main/java/com/mapbox/navigation/ui/RecenterButton.java#L142-L146

And
https://github.com/mapbox/mapbox-navigation-android/blob/master/libnavigation-ui/src/main/java/com/mapbox/navigation/ui/RecenterButton.java#L144
This line I believe is actually invalid, as nothing in the code will re-create the MultiOnClickListener again in this element.
as it is only created during creation of it, so if this element is re-attached it will misbehave and crash later:
https://github.com/mapbox/mapbox-navigation-android/blob/master/libnavigation-ui/src/main/java/com/mapbox/navigation/ui/RecenterButton.java#L29

According to https://stackoverflow.com/a/65227045 & https://proandroiddev.com/make-your-custom-view-lifecycle-aware-its-a-piece-of-cake-90b7c0498686 it appears onDetachFromWindow is NOT the place to cleanup/null things like this, as the view can be re-attached without being re-created if used in things like tabs/pagers. So nulling the listener will lead to a crash if it is re-attached. In addition it might be good if you checked to verify that the MultiOnClickListener isn't null in the clearListeners function on line 143 as something obviously called this function a second time...


System.err: Attempt to invoke virtual method 'void com.mapbox.navigation.ui.MultiOnClickListener.clearListeners()' on a null object reference
System.err: 
System.err: StackTrace:
System.err: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.mapbox.navigation.ui.MultiOnClickListener.clearListeners()' on a null object reference
System.err:     at com.mapbox.navigation.ui.RecenterButton.clearListeners(RecenterButton.java:143)
System.err:     at com.mapbox.navigation.ui.RecenterButton.onDetachedFromWindow(RecenterButton.java:135)
System.err:     at android.view.View.dispatchDetachedFromWindow(View.java:19607)
System.err:     at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3814)
System.err:     at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3806)
System.err:     at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3806)
System.err:     at android.view.ViewGroup.removeViewInternal(ViewGroup.java:5431)
System.err:     at android.view.ViewGroup.removeViewInternal(ViewGroup.java:5402)
System.err:     at android.view.ViewGroup.removeView(ViewGroup.java:5333)
System.err:     at android.view.ViewOverlay$OverlayViewGroup.remove(ViewOverlay.java:216)
System.err:     at android.view.ViewGroupOverlay.remove(ViewGroupOverlay.java:84)
System.err:     at androidx.transition.ViewGroupOverlayApi18.remove(ViewGroupOverlayApi18.java:53)
System.err:     at androidx.transition.Visibility$1.onTransitionEnd(Visibility.java:457)
System.err:     at androidx.transition.Transition.end(Transition.java:1965)
System.err:     at androidx.transition.Transition$3.onAnimationEnd(Transition.java:1914)
System.err:     at android.animation.Animator$AnimatorListener.onAnimationEnd(Animator.java:554)
System.err:     at android.animation.AnimatorSet.endAnimation(AnimatorSet.java:1301)
System.err:     at android.animation.AnimatorSet.doAnimationFrame(AnimatorSet.java:1086)
System.err:     at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:146)
System.err:     at android.animation.AnimationHandler.access$100(AnimationHandler.java:37)
System.err:     at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:54)
System.err:     at android.view.Choreographer$CallbackRecord.run(Choreographer.java:964)
System.err:     at android.view.Choreographer.doCallbacks(Choreographer.java:790)
System.err:     at android.view.Choreographer.doFrame(Choreographer.java:721)
System.err:     at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
System.err:     at android.os.Handler.handleCallback(Handler.java:883)
System.err:     at android.os.Handler.dispatchMessage(Handler.java:100)
System.err:     at android.os.Looper.loop(Looper.java:214)
System.err:     at android.app.ActivityThread.main(ActivityThread.java:7356)
System.err:     at java.lang.reflect.Method.invoke(Native Method)
System.err:     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia da libnavigation-ui/src/main/java/com/mapbox/navigation/ui/RecenterButton.java, in particolare da onDetachedFromWindow e clearListeners, e esamina lo stack trace fornito. Riproduci il crash passando dalla sample navigation app a un’altra app, quindi verifica che il distacco e il nuovo collegamento della view non causino più il crash dovuto a un oggetto null.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
android, kotlin
Ambito
mobile
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.