mapbox / mapbox/mapbox-navigation-android-examples
Migrate examples from `MapboxNavigationProvider` to `MapboxNavigationApp`
Personne n'a encore pris cette issue.
- Langage dominant
- Kotlin
- Étoiles
- 65
- Forks
- 56
- Merge moyen
- 1 j 4 h
- PR mergées (30 j)
- 2
Description
It will be some time before we upgrade the examples repository to `com.mapbox.navigation:android:2.8.0-alpha.2`.
Opening so we can start considering the migration, but we're still building tools that make migration easier
For example the [extensions](https://github.com/mapbox/mapbox-navigation-android/blob/main/libnavigation-core/src/main/java/com/mapbox/navigation/core/internal/extensions/MapboxLifecycleExtensions.kt) are still experimental.
- [ ] ShowAlternativeRoutesActivity
- [ ] ShowManeuversActivity
- [ ] MultipleWayPointsActivity
- [ ] ShowTripProgressActivity
- [ ] ShowCameraTransitionsActivity
- [ ] ShowCurrentLocationActivity
- [ ] ShowJunctionsActivity
- [ ] FetchARouteActivity
- [ ] RenderRouteLineActivity
- [ ] TurnByTurnExperienceActivity
- [ ] MapboxSignboardActivity
- [ ] PlayVoiceInstructionsActivity
- [ ] ShowSpeedLimitActivity
- [ ] ReplayHistoryActivity
- [ ] CustomArrivalActivity
- [ ] ShowBuildingExtrusionsActivity
## Migration plan
We want to commit to a migration plan for the examples repository by **September 5th** because that is the week the `2.8.0` release becomes a release candidate and we will be committed to apis for a stable release.
Note that, not-migrating and using `MapboxNavigation` directly is also an option. `MapboxNavigationApp` is built for large apps.
## Resources
The architecture is designed for you to build de-coupled classes like the [LocationComponent](https://github.com/mapbox/mapbox-navigation-android/blob/d8d04fe75e53063f5e185c3779c04c7b0914f77d/libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/component/location/LocationComponent.kt#L15-L39), or a more complicated example is the [CameraComponent](https://github.com/mapbox/mapbox-navigation-android/blob/d8d04fe75e53063f5e185c3779c04c7b0914f77d/libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/component/camera/CameraComponent.kt#L32-L242). There are other approaches that are worth considering.
Some public documentation on the `MapboxNavigationApp` can be found here https://docs.mapbox.com/android/navigation/guides/androidauto/car-app-lifecycle/
We will also explore migration ideas in the [qa-test-app](https://github.com/mapbox/mapbox-navigation-android/tree/main/qa-test-app)
## Ideas are welcome
I'm obviously not the only one using this new library, so feel free to bring in some opinions and ideas. Feel free to open a pull request against this [migrate-MapboxNavigationApp](https://github.com/mapbox/mapbox-navigation-android-examples/pull/129) branch. Or create new pull requests.
cc: @mapbox/navigation-android
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par le plan de migration et les activités d’exemple répertoriées, puis examinez la documentation de MapboxNavigationApp et la qa-test-app pour y trouver des modèles de migration. La branche migrate-MapboxNavigationApp et les ressources d’architecture liées fournissent un contexte supplémentaire. Le travail est considéré comme terminé soit lorsque les exemples répertoriés ont été migrés de manière cohérente, soit lorsqu’une décision de continuer à utiliser directement MapboxNavigation a été documentée.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- kotlin
- Domaine
- mobile
- Type d'issue
- Refactorisation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100