mapbox / mapbox/mapbox-java

Support feature id as a number

Open
#914 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

GeoJson
Dominant language
Java
Stars
438
Forks
117
PR merge metrics
No merged PRs in 30d

Description

Capturing from RFC

If a Feature has a commonly used identifier, that identifier SHOULD be included as a member of the Feature object with the name "id", and the value of this member is either a JSON string or number.

On a public API level we only expose String.java:

  /**
   * A feature may have a commonly used identifier which is either a unique String or number.
   *
   * @return a String containing this features unique identification or null if one wasn't given
   *   during creation.
   * @since 1.0.0
   */
  @Nullable
  public abstract String id();

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the public String.java API and the linked RFC 7946 section on Feature identifiers. Trace where the feature id type is defined and covered by tests, then identify the API changes needed for both JSON strings and numbers. Done means numeric identifiers are supported without losing existing string support.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.