Feature properties parameter declared as '@NonNull'
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 438
- Forks
- 117
- PR merge metrics
- No merged PRs in 30d
Description
As can be seen here, the properties parameter, which is required in the fromGeometry function, is declared as @NonNull, even though a null value is handled correctly in the function body.
Also all other fromGeometry functions declare their properties parameter as @Nullable.
I would expect this to be the case for said fromGeometry function, too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open services-geojson/src/main/java/com/mapbox/geojson/Feature.java around the fromGeometry function at line 179 and compare its properties annotation with the other fromGeometry functions. Done means the required function's annotation matches its null handling and the other overloads.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100