mapbox / mapbox/github-release-tools
Request review from original PR author when backporting a PR you reviewed
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 16
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
Currently if you backport a PR of behalf of someone else, and you were the approving reviewer on the original PR, backport will attempt to request a review on the new PR from yourself, which Github denies:
{ HttpError: {"message":"Review cannot be requested from pull request author.","documentation_url":"https://developer.github.com/v3/pulls/review_requests/#create-a-review-request"}
...
It should instead request a review from the original author.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the backport flow that requests reviews on the new pull request. Reproduce the case where the backporter approved the original pull request, then verify that the request targets the original author rather than the backporter and that GitHub no longer rejects it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- release
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100