mapbox / mapbox/duplicate-module-test

Fail or warn when module isn't found?

Open
#2 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Right now if a module isn't found, we exit `1` and fail. Output looks like this:

```
Checking for duplicate modules ...

tilelive was not found in the node_modules tree
```

Alternatively, we could just print a warning since this isn't necessarily a bad thing, it just means the module isn't being installed (presumably because it's not longer being used). Output could instead look like:

```
Checking for duplicate modules ...

✔ @mapbox/vtquery has only one version
? tilelive was not found in the node_modules tree
```

cc @mapbox/core-tech

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Start by locating the code that handles a module missing from the node_modules tree and review how its exit status and output are tested. Done means the project has a decided fail-or-warn behavior, matching output, and coverage for the missing-module case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.