mapbox / mapbox/MapboxGeocoder.swift
Sanitize semicolons from non-batch queries
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 133
- Forks
- 46
- PR merge metrics
- No merged PRs in 30d
Description
A non-batch query that contains a semicolon is implicitly treated as a batch query. GeocodeOptions should replace semicolons with commas or spaces to avoid getting back a response that it can’t parse. But its batch subclasses need to preserve semicolons.
/cc @captainbarbosa @frederoni @apendleton
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with GeocodeOptions and inspect how non-batch queries are constructed before being sent. Compare that behavior with the batch subclasses, which must preserve semicolons. Done means semicolons are replaced with commas or spaces for non-batch queries while batch queries retain them; no files or tests are named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api, mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100