mapbox / mapbox/MapboxGeocoder.swift

Geocoder Options For Allowed Region Does Not Work For Small Areas

Offen
#135 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Vorherrschende Sprache
Swift
Sterne
133
Forks
46
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

I tried to implement a search query for when a user types in an address. All of my users are in the same small area, so I created a relatively small bounding area for my search (~20 miles radius). But, for some reason, when I would search my desired address, which I know should be in my small region. It does not return the address when the user searches for it. The only way I could get the address to show up was to increase the allowed region to the entire state. I even checked that the desired location's coordinates were in the small region, and it returned true. Since my app is only supposed to work in this small city, I would like to be able to only allow the user to select addresses that are in the city and nothing else. Here is my code with comments about which region worked and which one did not:

private func createOptions(from address: String) -> ForwardGeocodeOptions {
        let options = ForwardGeocodeOptions(query: address)
        options.allowedISOCountryCodes = ["US"]
        
        let indianaUniversity = CLLocation(latitude: 39.1745704, longitude: -86.5173232)
        options.focalLocation = indianaUniversity
        options.allowedScopes = [.address, .pointOfInterest]
        options.allowedRegion = createBoundingBox()
        return options
    }
    
    private func createBoundingBox() -> RectangularRegion {
        let pointOfInterest = CLLocationCoordinate2D(latitude: 39.163899999999998, longitude: -86.522330999999994)
        
        //Works:
        //This covers the entire state of Indiana
        let indianaNortheastCorner = CLLocationCoordinate2D(latitude: 41.722131, longitude: -84.80896)
        let indianaSouthwestCorner = CLLocationCoordinate2D(latitude: 37.822802, longitude: -88.027954)
        let indianaRegion = RectangularRegion(southWest: indianaSouthwestCorner, northEast: indianaNortheastCorner)
        
        //return true
        indianaRegion.containsLocationCoordinate2D(pointOfInterest)
        
        //Does not work:
        //This just covers the Bloomington County area.
        let southwestCorner = CLLocationCoordinate2D(latitude: 0, longitude: -86.87026977539062)
        let northeastCorner = CLLocationCoordinate2D(latitude: 39.25352462727606, longitude: -86.28971099853516)
        let smallRegion = RectangularRegion(southWest: southwestCorner, northEast: northeastCorner)
        
        //returns true
        smallRegion.containsLocationCoordinate2D(pointOfInterest)
        
        
        return indianaRegion
    }`

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne damit, die gemeldete Suche über createOptions(from:) und createBoundingBox() nachzustellen, und konzentriere dich auf ForwardGeocodeOptions.allowedRegion und RectangularRegion. Vergleiche die kleinen und landesweiten Regionen anhand der bereitgestellten Koordinaten und überprüfe anschließend, dass der Geocoder Adressen innerhalb des vorgesehenen Bereichs zurückgibt und andere ausschließt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
swift
Bereich
api, mobile-dev
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.