mapbox / mapbox/MapboxGeocoder.swift

Geocoder Options For Allowed Region Does Not Work For Small Areas

Open
#135 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
133
Forks
46
PR merge metrics
No merged PRs in 30d

Description

I tried to implement a search query for when a user types in an address. All of my users are in the same small area, so I created a relatively small bounding area for my search (~20 miles radius). But, for some reason, when I would search my desired address, which I know should be in my small region. It does not return the address when the user searches for it. The only way I could get the address to show up was to increase the allowed region to the entire state. I even checked that the desired location's coordinates were in the small region, and it returned true. Since my app is only supposed to work in this small city, I would like to be able to only allow the user to select addresses that are in the city and nothing else. Here is my code with comments about which region worked and which one did not:

private func createOptions(from address: String) -> ForwardGeocodeOptions {
        let options = ForwardGeocodeOptions(query: address)
        options.allowedISOCountryCodes = ["US"]
        
        let indianaUniversity = CLLocation(latitude: 39.1745704, longitude: -86.5173232)
        options.focalLocation = indianaUniversity
        options.allowedScopes = [.address, .pointOfInterest]
        options.allowedRegion = createBoundingBox()
        return options
    }
    
    private func createBoundingBox() -> RectangularRegion {
        let pointOfInterest = CLLocationCoordinate2D(latitude: 39.163899999999998, longitude: -86.522330999999994)
        
        //Works:
        //This covers the entire state of Indiana
        let indianaNortheastCorner = CLLocationCoordinate2D(latitude: 41.722131, longitude: -84.80896)
        let indianaSouthwestCorner = CLLocationCoordinate2D(latitude: 37.822802, longitude: -88.027954)
        let indianaRegion = RectangularRegion(southWest: indianaSouthwestCorner, northEast: indianaNortheastCorner)
        
        //return true
        indianaRegion.containsLocationCoordinate2D(pointOfInterest)
        
        //Does not work:
        //This just covers the Bloomington County area.
        let southwestCorner = CLLocationCoordinate2D(latitude: 0, longitude: -86.87026977539062)
        let northeastCorner = CLLocationCoordinate2D(latitude: 39.25352462727606, longitude: -86.28971099853516)
        let smallRegion = RectangularRegion(southWest: southwestCorner, northEast: northeastCorner)
        
        //returns true
        smallRegion.containsLocationCoordinate2D(pointOfInterest)
        
        
        return indianaRegion
    }`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported search through createOptions(from:) and createBoundingBox(), focusing on ForwardGeocodeOptions.allowedRegion and RectangularRegion. Compare the small and statewide regions using the supplied coordinates, then verify the geocoder returns addresses inside the intended area while excluding others.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
api, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.