maliput / maliput/maliput_malidrive
When using automatic tolerance selection the builder creates entities passed in as dependencies.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 4
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
After #77 was merged, the builder is creating entities like:
- [DBManager](https://github.com/ToyotaResearchInstitute/maliput_malidrive/blob/main/maliput_malidrive/src/maliput_malidrive/builder/road_geometry_builder.cc#L265-L266)
- [RoadGeometryConfiguration](https://github.com/ToyotaResearchInstitute/maliput_malidrive/blob/main/maliput_malidrive/src/maliput_malidrive/builder/road_geometry_builder.cc#L275-L277)
- [RoadCruveFactory](https://github.com/ToyotaResearchInstitute/maliput_malidrive/blob/main/maliput_malidrive/src/maliput_malidrive/builder/road_geometry_builder.cc#L280-L282)
We should consider changing the RoadGeometyBuilder to introduce providers rather than entities to deal with this inconsistency.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in maliput_malidrive/src/maliput_malidrive/builder/road_geometry_builder.cc at the referenced lines around 265-282, and trace how automatic tolerance selection constructs DBManager, RoadGeometryConfiguration, and RoadCruveFactory. Clarify the provider-versus-entity design and identify the expected ownership and construction boundaries; done means the inconsistency is resolved without creating dependency entities.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100