macvim-dev / macvim-dev/macvim

Adding filetype icons for more formats

未关闭
#1,696 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
Vim Script
星标
7.9k
派生
691
PR 合并指标
30 天内没有已合并 PR

描述

I've been working with .ts and .tsx files as part of a next.js development. Both of these filetypes have syntax support, but MacVim doesn't come bundled with icons for these filetypes. I was able to generate some on my own and, with a few hacks on the command line, get my own macvim installation to show them in finder, and get finder to use macvim to open them.

I thought about trying to add these icons here to the repo, but wanted to check with the dev team first on a few things:

  1. Is there an established template for these icon files? I just photoshopped these together quickly (matching the font/colors/etc. of existing filetype icons), but if there's a source file I could simply edit and export to the same format you already use, I'd rather do that, and generate assets that match what you already are using
  2. The CONTRIBUTING.md file here looks like it comes from vim directly, but regardless, there's a note in there about "not causing trouble with trademarks" -- I think these files are above board (i.e., they don't use any microsoft design language, just plain TS and TSX text), but want to make sure this is OK

I also know it takes more than just creating some images to get this to work -- namely some changes in the main Info.plist for the app to handle the associations properly -- but will hold on any of that until I get a nod here one way or another.

Finally, .ts is also apparently an extension tied to a standard MPEG video format, and if you have an app like VLC installed, it wants to claim the association instead. Just a possible collision that could result if we wanted the app to try to associate itself with that filetype.

Image Image

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

先检查现有的文件类型图标资源和 CONTRIBUTING.md,以了解既定的模板和商标指导,然后检查应用在 Info.plist 中对文件关联的处理方式。完成的标准是添加匹配的 .ts 和 .tsx 图标,并解决文件关联行为(包括可能的 .ts MPEG 冲突)或明确记录该问题。

由索引模型根据 Issue 内容生成。

评估

技术栈
macos, vim
领域
design, desktop
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
48/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。