macvim-dev / macvim-dev/macvim
Adding filetype icons for more formats
Nobody has claimed this yet.
- Dominant language
- Vim Script
- Stars
- 7.9k
- Forks
- 691
- PR merge metrics
- No merged PRs in 30d
Description
I've been working with .ts and .tsx files as part of a next.js development. Both of these filetypes have syntax support, but MacVim doesn't come bundled with icons for these filetypes. I was able to generate some on my own and, with a few hacks on the command line, get my own macvim installation to show them in finder, and get finder to use macvim to open them.
I thought about trying to add these icons here to the repo, but wanted to check with the dev team first on a few things:
- Is there an established template for these icon files? I just photoshopped these together quickly (matching the font/colors/etc. of existing filetype icons), but if there's a source file I could simply edit and export to the same format you already use, I'd rather do that, and generate assets that match what you already are using
- The
CONTRIBUTING.mdfile here looks like it comes from vim directly, but regardless, there's a note in there about "not causing trouble with trademarks" -- I think these files are above board (i.e., they don't use any microsoft design language, just plain TS and TSX text), but want to make sure this is OK
I also know it takes more than just creating some images to get this to work -- namely some changes in the main Info.plist for the app to handle the associations properly -- but will hold on any of that until I get a nod here one way or another.
Finally, .ts is also apparently an extension tied to a standard MPEG video format, and if you have an app like VLC installed, it wants to claim the association instead. Just a possible collision that could result if we wanted the app to try to associate itself with that filetype.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the existing filetype icon assets and CONTRIBUTING.md for the established template and trademark guidance, then inspect the app's Info.plist handling of file associations. Done means matching .ts and .tsx icons are added and the association behavior, including the possible .ts MPEG collision, is resolved or explicitly documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- macos, vim
- Domain
- design, desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100