MapMask is broken
Open
@ternaus is already working on this.
Since Nov 13, 2019.
bug
- Dominant language
- Jupyter Notebook
- Stars
- 390
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Description
I'd like to report the following problems with MapMask:
1. It uses `foreground=255`, but if you look to the map, you'll notice that white color means background.
2. Function `is_on_mask` is broken because it ignores 3 channels of RGB picture. (Python complains about indexing). The fix would be to check if all channels are white or non-white, like:
`mask = np.all(this_mask[py[on_mask], px[on_mask]], axis=-1)`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.