A small issue in render_annotation function
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 390
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Description
Hey,
In `render_annotation` function you don't need a for loop ([here](https://github.com/lyft/nuscenes-devkit/blob/master/lyft_dataset_sdk/lyftdataset.py#L1083)) as there will always be one box in `boxes` (we are doing assertion checks for the same). And you are passing `boxes[0]` to `view_points` within the loop anyways. ([here](https://github.com/lyft/nuscenes-devkit/blob/master/lyft_dataset_sdk/lyftdataset.py#L1086))
And, this time I wanna fix this by raising a PR, do let me know if I can process with that :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open lyft_dataset_sdk/lyftdataset.py around lines 1083-1086 and inspect the assertion that ensures boxes contains one item, then review how boxes[0] is passed to view_points. The refactor is done when render_annotation preserves its current output without iterating unnecessarily; verify it with the relevant rendering or dataset tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- autonomous-driving, computer-vision
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100