loopbackio / loopbackio/loopback-next
Use FQIN in Dockerfile
A pull request for this has already been merged.
- #9842 by @achrinza — merged
- Dominant language
- TypeScript
- Stars
- 5.1k
- Forks
- 1.1k
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 27
Description
Historically, we have used Unqualified Image Names. However, this is insecure as it is ambiguous on registry to use. Fully Qualified Image Names (FQIN) make explicit the domain name of the registry to pull from.
Change details
For Dockerfiles, the general update will be:
+ FROM docker.io/library/node:18-slim
- FROM node:18-slim
Although there is special-handling for the docker.io registry that allows omission of /library namespace path prefix for "no-namespace" images, we should use the full FQIN so as to be consistent with the output of other utilities such as podman image ls.
Impact
Other than updated Dockerfiles, there should be no other noticeable impact.
Files to update
loopback-next- docs/site/Application-generator.md
- examples/access-control-migration/Dockerfile
- examples/multi-tenancy/Dockerfile
- examples/references-many/Dockerfile
- examples/rest-crud/Dockerfile
- examples/socketio/Dockerfile
- examples/todo/Dockerfile
- examples/todo-jwt/Dockerfile
- examples/todo-list/Dockerfile
- packages/cli/generators/app/templates/Dockerfile
create-loopbackloopback4-example-shoppingloopback-blogstarter
References
- https://github.com/search?q=org%3Aloopbackio%20language%3ADockerfile&type=code
- https://github.com/search?q=org%3Aloopbackio+%22FROM+node%3A%22&type=code
- https://github.com/containers/image/blob/95a2847696c8583d5bed0ce71fed3a32276aa870/docs/containers-registries.conf.5.md#note-risk-of-using-unqualified-image-names
Similar changes in other projects
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the listed Dockerfiles, Dockerfile templates, documentation, and bin/dockerize.js across the named repositories, starting with the referenced lines and the repository-wide search links. Update each affected image reference consistently, then search the listed repositories again to confirm the targeted unqualified references are gone; the issue states that no other behavior should change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, dockerfile
- Domain
- devops, infrastructure
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100