loopbackio / loopbackio/loopback-next

Use FQIN in Dockerfile

Open
#9,841 0 comments 0 reactions 0 assignees View on GitHub

A pull request for this has already been merged.

  • #9842 by @achrinza — merged
Dominant language
TypeScript
Stars
5.1k
Forks
1.1k
Avg merge
2d 21h
Merged PRs (30d)
27

Description

Historically, we have used Unqualified Image Names. However, this is insecure as it is ambiguous on registry to use. Fully Qualified Image Names (FQIN) make explicit the domain name of the registry to pull from.

Change details

For Dockerfiles, the general update will be:

+ FROM docker.io/library/node:18-slim
- FROM node:18-slim

Although there is special-handling for the docker.io registry that allows omission of /library namespace path prefix for "no-namespace" images, we should use the full FQIN so as to be consistent with the output of other utilities such as podman image ls.

Impact

Other than updated Dockerfiles, there should be no other noticeable impact.

Files to update

References

Similar changes in other projects

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the listed Dockerfiles, Dockerfile templates, documentation, and bin/dockerize.js across the named repositories, starting with the referenced lines and the repository-wide search links. Update each affected image reference consistently, then search the listed repositories again to confirm the targeted unqualified references are gone; the issue states that no other behavior should change.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, dockerfile
Domain
devops, infrastructure
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.