loopbackio / loopbackio/loopback-next

Make getFilterJsonSchemaFor() model-aware

Offen
#4,977 8 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@agnes512 arbeitet bereits daran.

Seit 02.4.2020.

bug
Vorherrschende Sprache
TypeScript
Sterne
5.1k
Forks
1.1k
Ø Merge
2 T. 21 Std.
Gemergte PRs (30 T.)
27

Beschreibung

Currently, getFilterJsonSchemaFor() isn't model-aware.

This means that the openapi.json order filter parameter will be generic:

image

In the case above, it's the /todos parameter from the Todo example.

This would lead to issues where the suggested order filter isn't a valid query:

image

(Notice the "order": [ "string" ])

Steps to reproduce

A quick way to reproduce is use the Todo example:

lb4 example todo

This also applies to any LoopBack 4 application that utilises @param.filter(ModelHere).

Expected Behavior

The order filter should be model-aware and not generic.

Link to reproduction sandbox

lb4 example todo

Additional information

$ node -e 'console.log(process.platform, process.arch, process.versions.node)' && \
>   npm ls --prod --depth 0 | grep loopback
win32 x64 12.16.1
@loopback/example-todo@3.0.2 C:\Users\rifaa\Documents\loopback4-example-todo
+-- @loopback/boot@2.0.2
+-- @loopback/context@3.2.0
+-- UNMET PEER DEPENDENCY @loopback/core@2.2.0
+-- @loopback/openapi-v3@3.1.1
+-- UNMET PEER DEPENDENCY @loopback/repository@2.0.2
+-- @loopback/rest@3.1.0
+-- @loopback/rest-explorer@2.0.2
+-- @loopback/service-proxy@2.0.2
npm+-- loopback-connector-rest@3.6.0
 ERR! peer dep missing: @loopback/core@^1.12.0, required by @loopback/model-api-builder@2.0.2
npm ERR! peer dep missing: @loopback/repository@^1.16.0, required by @loopback/model-api-builder@2.0.2
npm ERR! peer dep missing: @loopback/core@^1.12.0, required by @loopback/model-api-builder@2.0.2
npm ERR! peer dep missing: @loopback/repository@^1.16.0, required by @loopback/model-api-builder@2.0.2
npm ERR! peer dep missing: @loopback/core@^1.12.0, required by @loopback/model-api-builder@2.0.2
npm ERR! peer dep missing: @loopback/repository@^1.16.0, required by @loopback/model-api-builder@2.0.2
npm ERR! peer dep missing: @loopback/core@^1.12.0, required by @loopback/model-api-builder@2.0.2
npm ERR! peer dep missing: @loopback/core@^1.12.0, required by @loopback/model-api-builder@2.0.2
npm ERR! peer dep missing: @loopback/core@^1.12.0, required by @loopback/model-api-builder@2.0.2

Related Issues

N/A

See Reporting Issues for more tips on writing good issues

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.