Sugar API for defining URL redirects

This is a follow-up for https://github.com/strongloop/loopback-next/pull/2014.

When using LB4+ to serve HTML pages, it's useful to add a trailing slash to the URL when serving a folder, for example redirect /explorer to /explorer/. Without this redirect, relative URLs to assets like CSS & JS files are incorrectly resolved. For example, when served from /explorer, relative links like ./swagger-ui.css are resolved in the parent directory, e.g. /swagger-ui.css instead of /explorer/swagger-ui.css.

Right now, a redirect can be implemented using a controller route that's hidden from the documentation and uses HTTP response object to send back the redirect. Such solution requires a lot of code and feels a bit hacky.

Let's make redirects a first-class feature in LB4 and provide a high-level API that's easy to use.

For example:

restApp.redirect('/explorer', '/explorer/');
restServer.redirect('/explorer', '/explorer/');

Under the hood, this can be implemented as a new Route class, for example:

app.route(new RedirectRoute('/explorer', '/explorer/'));

A mock-up implementation of RedirectRoute:

export class RedirectRoute implements RouteEntry, ResolvedRoute {
  // ResolvedRoute API
  readonly pathParams: PathParameterValues = [];
  readonly schemas: SchemasObject = {};

  // RouteEntry implementation
  readonly verb: string = 'get';
  readonly get path(): string { return this.sourcePath; }
  // ...

  constructor(
    public readonly sourcePath: string, 
    public readonly targetPath: string, 
    public statusCode: number = 303,
  ) {
    this.path = sourcePath;
  }

  async invokeHandler(
    {response}: RequestContext,
    args: OperationArgs,
  ): Promise<OperationRetval> {
    response.redirect(this.statusCode, this.targetPath);
  }

  // ...
}

Acceptance criteria

https://github.com/strongloop/loopback-next/pull/2512

• The implementation, including unit/integration/acceptance tests
  • Most of the tests should be written for RestServer.
  • Add one or few tests for RestApplication at integration or acceptance level, just to ensure the new RestApplication API is covered.
• Documentation

TODO

• Redirect to dynamically computed location (see the discussion below)
• Search for all places calling .redirect( and consider updating them to use the new route and/or the new RestServer/RestApplication sugar APIs. E.g. REST API Explorer.
  • Redirect to externally hosted swagger-ui
  • Redirect from /explorer to /explorer/
• Redirect to a location that's full URL (http://example.com) instead of a local path (/home). The trick is to skip appending basePath.
• Honor req.baseUrl when the LB4 app is mounted on an external Express application.

Commencez par examiner la pull request 2512 référencée ainsi que les API RestServer et RestApplication décrites dans l’issue. Vérifiez les tests unitaires, d’intégration et d’acceptation concernant le comportement des redirections, puis comparez les TODOs restants avec l’implémentation documentée afin de déterminer s’il reste du travail à effectuer.