loopbackio / loopbackio/loopback-connector-sqlite3
Fix date parsing/validity check
@kraman 已经在做这个了。
开始于 2015年6月28日。
- 主要语言
- JavaScript
- 星标
- 13
- 派生
- 21
- PR 合并指标
- 30 天内没有已合并 PR
描述
The tests are passing on CI, but this is in the console:
```
Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to https://github.com/moment/moment/issues/1407 for more info.
Error
at deprecate (/Users/ryan/work/loopback-connector-sqlite3/node_modules/moment/moment.js:738:42)
at /Users/ryan/work/loopback-connector-sqlite3/node_modules/moment/moment.js:826:50
at /Users/ryan/work/loopback-connector-sqlite3/node_modules/moment/moment.js:8:85
at Object. (/Users/ryan/work/loopback-connector-sqlite3/node_modules/moment/moment.js:11:2)
at Module._compile (module.js:428:26)
at Object.Module._extensions..js (module.js:446:10)
at Module.load (module.js:353:32)
at Function.Module._load (module.js:308:12)
at Module.require (module.js:363:17)
at require (module.js:382:17)
at Object. (/Users/ryan/work/loopback-connector-sqlite3/lib/sqlite3.js:10:14)
at Module._compile (module.js:428:26)
at Object.Module._extensions..js (module.js:446:10)
at Module.load (module.js:353:32)
at Function.Module._load (module.js:308:12)
at Module.require (module.js:363:17)
at require (module.js:382:17)
at Object. (/Users/ryan/work/loopback-connector-sqlite3/index.js:1:80)
at Module._compile (module.js:428:26)
at Object.Module._extensions..js (module.js:446:10)
at Module.load (module.js:353:32)
at Function.Module._load (module.js:308:12)
at Module.require (module.js:363:17)
at require (module.js:382:17)
at global.getDataSource.global.getSchema (/Users/ryan/work/loopback-connector-sqlite3/test/init.js:6:27)
at Context. (/Users/ryan/work/loopback-connector-sqlite3/test/sqlite.dbdefaults.test.js:10:10)
at callFn (/Users/ryan/work/loopback-connector-sqlite3/node_modules/mocha/lib/runnable.js:266:21)
at Hook.Runnable.run (/Users/ryan/work/loopback-connector-sqlite3/node_modules/mocha/lib/runnable.js:259:7)
at next (/Users/ryan/work/loopback-connector-sqlite3/node_modules/mocha/lib/runner.js:271:10)
at Immediate._onImmediate (/Users/ryan/work/loopback-connector-sqlite3/node_modules/mocha/lib/runner.js:292:5)
at processImmediate [as _immediateCallback] (timers.js:371:17)
[Error: Invalid date default: '5']
```
**edit:** replaced deprecation with output from a non-coverage run of `npm test`
贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。