llvm / llvm/circt

[CI] clang-tidy checks unexpectedly pass in "Build and Test" workflow

Open
#9,361 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

Might be a duplicate of #4713 but I'm pretty sure it has been working in between then and now. E.g., this would (and should) have been a failure in the past:
https://github.com/llvm/circt/actions/runs/19554867260/job/55994912078

```
Run if git diff -U0 $DIFF_COMMIT...HEAD | clang-tidy-diff -path build -p1 -fix -j$(nproc); then
/usr/bin/clang-tidy-diff:220: SyntaxWarning: invalid escape sequence '\+'
match = re.search('^\+\+\+\ "?(.*?/){%s}([^ \t\n"]*)' % args.p, line)
/usr/bin/clang-tidy-diff:233: SyntaxWarning: invalid escape sequence '\+'
match = re.search("^@@.*\+(\d+)(,(\d+))?", line)
11498 warnings generated.

Suppressed 11502 warnings (11497 in non-user code, 1 due to line filter, 4 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

69614 warnings generated.
clang-tidy applied 1 of 1 suggested fixes.
Suppressed 69616 warnings (69602 in non-user code, 10 due to line filter, 4 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/circt/circt/lib/Conversion/HWToLLVM/HWToLLVM.cpp:109:11: warning: replace loop by 'std::any_of()' [readability-use-anyofallof]
109 | for (auto user : arrVal.getUsers())
| ^
/__w/circt/circt/lib/Conversion/HWToLLVM/HWToLLVM.cpp:109:16: warning: 'auto user' can be declared as 'auto *user' [llvm-qualified-auto]
109 | for (auto user : arrVal.getUsers())
| ^~~~
| auto *
/__w/circt/circt/lib/Conversion/HWToLLVM/HWToLLVM.cpp:109:16: note: FIX-IT applied suggested code changes

88431 warnings generated.
Suppressed 88435 warnings (88431 in non-user code, 4 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
```

Would be nice to have the patch files uploaded again. Does anyone recall it ever failing after #7355?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Build and Test workflow and the clang-tidy-diff command shown in the linked action run. Compare its behavior with issues #4713 and #7355, including whether patch files are uploaded. Done means the workflow fails when clang-tidy reports the demonstrated warnings and uploads the expected patch files.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.