Ensure dialect dependencies are captured in ODS
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
In a Dialect definition in ODS, you can specify the [dependent dialects](https://github.com/llvm/llvm-project/blob/a623051dc3011fe6f41bddab4024fc213f60282b/mlir/include/mlir/IR/OpBase.td#L242-L245). Right now, we have only 1 dialect explicitly depending on another. Presumably, there are other dependencies which are not explicitly handled, and we should comb through the dialects and see what is missing. We should also find a way to test that the dependency is working.
A bit more information here: https://github.com/llvm/circt/pull/925#discussion_r615005019
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MLIR ODS Dialect definition and its dependent-dialects documentation, then review the discussion in PR 925. Comb through the CIRCT dialect definitions to identify dependencies that are not explicitly captured. Done means the missing dependencies are declared and a test demonstrates that dependency handling works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100