llvm / llvm/circt

[Arc] Flatten public modules

Open
#8,232 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Arc bug
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

Arcilator is currently very easy to break if a public module is instantiated anywhere. In that case the module hierarchy does not get flattened completely, but the public module remains as an instance instead. This makes the instance behave like an external module. Fix the module flattening to also fully inline public modules (but instead also keep the public module itself around as a top-level entry point).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Arcilator's module-flattening entry point and reproduce the case where a public module is instantiated. Done means instantiated public modules are fully inlined, while each public module remains available as a top-level entry point; add or update coverage for this behavior if the existing flattening tests are found.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.