[HandshakeToDC] Tech debt: clk/rst inserted later than they probably should be
Open
Nobody has claimed this yet.
HandshakeToDC
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
In #7825 I track the `hw.module`s which have been created then after everything is done add the clk and rst ports. This is not the desirable way to achieve this but all of the better ways I tried resulted in block args getting confused. Fix this.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #7825 and the HandshakeToDC implementation, focusing on where hw.module instances are created and where clk and rst ports are added. The work is done when those ports can be introduced without confusing block arguments and the resulting modules remain correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100