llvm / llvm/circt

[FIRRTL] in `replSeqMem` stands for "replace sequential memories" not "replicate sequential memories"

Open
#7,384 4 comments 4 reactions 0 assignees View on GitHub
FIRRTL good first issue
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

We have some flags named `shouldReplicateSequentialMemories`, but AFAICT this is incorrectly named and should be called `shouldReplaceSequentialMemories`. See the search result: https://github.com/search?q=repo%3Allvm%2Fcirct%20shouldReplicateSequentialMemories&type=code

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the repository code search for `shouldReplicateSequentialMemories` linked in the issue and inspect every occurrence. Rename the flag to `shouldReplaceSequentialMemories` consistently, then verify that no old spelling remains in the CIRCT source.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.