llvm / llvm/circt

[FIRRTL] FullAsynchronousResetTransform should be moved out of InferResets

Open
#7,270 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

FIRRTL
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

The InferResetsPass implements what is logically two separate passes, and it would be cleaner to make that distinction concrete.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating InferResetsPass and FullAsynchronousResetTransform in the FIRRTL implementation and reading how the current pass combines their responsibilities. Separate the two logical passes while preserving existing behavior; done means FullAsynchronousResetTransform no longer lives inside InferResets.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.