[ESI] RPCServer::registerReadPort provides no way to register callback port
Open
@teqdruid is already working on this.
Since Jun 26, 2024.
ESI
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
RegisterReadPort currently calls the default underlying connect() function, which forces a port to be a polling port.
https://github.com/llvm/circt/blob/34c73c35c89588c84f695c6021f8c74ec6337d2d/lib/Dialect/ESI/runtime/cosim/lib/RpcServer.cpp#L170-L176
There should be some way of registering a callback port, i.e. by providing an optional callback argument to registerReadPort.
e.g.:
ReadChannelPort & registerReadPort(const std::string &name, const std::string &type, std::function<bool(MessageData)> callback = nullptr);
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.