llvm / llvm/circt

[HW] hw.module.extern does not print non-identifier names correctly

Open
#7,040 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug HW
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

hw.module.extern @foo(in %t "h ^hello" : i32)

is printed by circt-opt as

hw.module.extern @foo(in %h ^hello : i32)

which is not valid.

I may try to fix this if I have time but if anyone wants to beat me to it feel free.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the example with circt-opt and trace the hw.module.extern printing entry point. Compare the handling of the quoted non-identifier name with the emitted operand name; done means the same input prints valid CIRCT syntax without dropping the required quoting or escaping.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.