llvm / llvm/circt

Factor out ClockEdgeAttr definitions

Open
#7,034 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

Quite a few of our dialects define a `ClockEdgeAttr` to allow ops to specify which clock edge they are sensitive to, such as `posedge`, `negedge`, and both `edge`s. It would be great if we had one definition of `ClockEdgeAttr` somewhere, for example in the HW dialect, and then used that definition from all other dialects that need it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing ClockEdgeAttr definitions across the dialects and inspect the HW dialect as the proposed shared location. Trace which dialects use these attributes and compare their definitions. Done means one shared ClockEdgeAttr definition is used consistently by every dialect that needs posedge, negedge, or both-edge sensitivity.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.